migrate to artifact instead of task, make interface more flexible

include/actsim_agent/task_interface.hpp

@@ -31,10 +31,15 @@
 #include <atomic>
 #include <condition_variable>
 #include <mutex>
-#include <cluster/task.hpp>
+#include <cluster/artifact.hpp>
+
+// if you want to use this interface for different types, you only need to change it here
+using InputType = pl::SimConfigArtifact;
+using OutputType = pl::SimOutputArtifact;
 
 class TaskInterface {
 
+
     public:
 
     TaskInterface(size_t buffer_size);
@@ -48,10 +53,10 @@ class TaskInterface {
     void notify_download_program_halt();
     void notify_workers_program_halt();
 
-    void push_fresh(std::unique_ptr<Task> task);
+    void push_fresh(std::unique_ptr<InputType> task);
-    std::unique_ptr<Task> pop_fresh(bool& empty);
+    std::unique_ptr<InputType> pop_fresh(bool& empty);
-    void push_finished(std::unique_ptr<Task> task);
+    void push_finished(std::unique_ptr<OutputType> task);
-    std::unique_ptr<Task> pop_finished(bool& empty);
+    std::unique_ptr<OutputType> pop_finished(bool& empty);
     size_t get_buffer_space();
 
     bool search_and_increment(db::uuid_t id, std::string& design);
@@ -70,8 +75,8 @@ class TaskInterface {
 
     size_t buffer_size;
 
-    std::queue<std::unique_ptr<Task>> fresh_queue;
+    std::queue<std::unique_ptr<InputType>> fresh_queue;
-    std::queue<std::unique_ptr<Task>> finished_queue;
+    std::queue<std::unique_ptr<OutputType>> finished_queue;
 
     volatile std::atomic_bool running_ = std::atomic_bool(true);
     volatile std::atomic_bool immediate_stop;

include/actsim_agent/uploader.hpp

@@ -43,7 +43,7 @@ class Uploader {
     private:
 
     void thread_run();
-    bool upload_task(std::unique_ptr<Task> task);
+    bool upload_task(std::unique_ptr<OutputType> task);
 
     std::unique_ptr<std::thread> uploader_thread;
     std::unique_ptr<db::Connection> conn;

include/actsim_agent/worker.hpp

@@ -46,7 +46,7 @@ class Worker {
     private:
 
     void thread_run();
-    bool perform_task(std::unique_ptr<Task>& task);
+    std::unique_ptr<OutputType> perform_task(std::unique_ptr<InputType> task, bool& finished);
 
     std::unique_ptr<std::thread> worker_thread;
     std::atomic<db::uuid_t> current_task;

src/actsim_agent/monitor.cpp

@@ -25,7 +25,6 @@
 
 #include <cluster/db_types.hpp>
 #include <cluster/db_client.hpp>
-#include <cluster/task.hpp>
 #include <chrono>
 #include "util.h"
 #include "monitor.hpp"
@@ -81,7 +80,7 @@ void Monitor::thread_run() {
             if ((task = worker->get_current_task()) != 0) {
 
                 // if the job they belong to was halted, cancel the task execution
-                if (this->conn->get_task_status(task) == JobStatusType::HALTED) {
+                if (this->conn->get_task_status(task) == db::JobStatusType::HALTED) {
                     DEBUG_PRINT("Task " + db::to_string(task) + " was halted, cancelling execution.");
                     worker->cancel_current();
                 }

src/actsim_agent/task_interface.cpp

@@ -29,7 +29,7 @@ TaskInterface::TaskInterface(size_t buffer_size) {
     this->buffer_size = buffer_size;
 }
 
-void TaskInterface::push_fresh(std::unique_ptr<Task> task) {
+void TaskInterface::push_fresh(std::unique_ptr<InputType> task) {
 
     // lock the queue and insert into it
     std::lock_guard<std::mutex> lock(this->fresh_queue_mutex);
@@ -49,20 +49,20 @@ bool TaskInterface::finished_queue_empty() {
     return this->finished_queue.empty();
 }
 
-std::unique_ptr<Task> TaskInterface::pop_fresh(bool& empty) {
+std::unique_ptr<InputType> TaskInterface::pop_fresh(bool& empty) {
 
     // we first need exclusive access to the queue
     std::lock_guard<std::mutex> lock (this->fresh_queue_mutex);
 
     // we have to make sure the queue wasn't emptied since the last empty call was made
     // or at least inform the calling thread that the queue is currently empty
-    std::unique_ptr<Task> task;
+    std::unique_ptr<InputType> task;
 
     if (!(empty = this->fresh_queue.empty())) {
         task = std::move(this->fresh_queue.front());
         
         // if the task needs to be simulated by multiple workers, don't remove it from the queue
-        if (task->task_type != TaskTypeType::MULTI_COV) {
+        if (!task->parallelizable()) {
             this->fresh_queue.pop();
             this->fresh_queue_full_condition.notify_one();
         }
@@ -92,7 +92,7 @@ void TaskInterface::wait_for_buffer_consume() {
     this->fresh_queue_full_condition.wait(lock, [&] { return this->get_buffer_space() > 0 || !running(); });
 }
 
-void TaskInterface::push_finished(std::unique_ptr<Task> task) {
+void TaskInterface::push_finished(std::unique_ptr<OutputType> task) {
     std::lock_guard<std::mutex> lock(this->finished_queue_mutex);
     this->finished_queue.push(std::move(task));
 
@@ -100,14 +100,14 @@ void TaskInterface::push_finished(std::unique_ptr<Task> task) {
     this->finished_queue_empty_condition.notify_one();
 }
 
-std::unique_ptr<Task> TaskInterface::pop_finished(bool& empty) {
+std::unique_ptr<OutputType> TaskInterface::pop_finished(bool& empty) {
 
     // we first need exclusive access to the queue
     std::lock_guard<std::mutex> lock (this->finished_queue_mutex);
 
     // we have to make sure the queue wasn't emptied since the last empty call was made
     // or at least inform the calling thread that the queue is currently empty
-    std::unique_ptr<Task> task;
+    std::unique_ptr<OutputType> task;
 
     if (!(empty = this->finished_queue.empty())) {
         auto task = std::move(this->finished_queue.front());

src/actsim_agent/uploader.cpp

@@ -99,7 +99,7 @@ void Uploader::thread_run() {
     }
 }
 
-bool Uploader::upload_task([[maybe_unused]]std::unique_ptr<Task> task) {
+bool Uploader::upload_task([[maybe_unused]]std::unique_ptr<OutputType> task) {
 
     // make sure any task that is uploaded isn't halted in the database
 

src/actsim_agent/worker.cpp

@@ -58,27 +58,29 @@ void Worker::thread_run() {
         // we're still good to go! get a task from the fresh queue
         bool queue_empty;
         auto task = this->interface.pop_fresh(queue_empty);
-        this->current_task.store(task->uuid, std::memory_order_relaxed);
+        this->current_task.store(task->id, std::memory_order_relaxed);
 
         // we need to make sure the queue wasn't emptied between waiting and getting new data
         if (queue_empty) continue;
 
         // everything is good, perform the given task
-        bool complete = this->perform_task(task);
+        bool complete;
         this->current_task.store(db::uuid_t(), std::memory_order_relaxed);
+        auto output = this->perform_task(std::move(task), complete);
 
         // if the task was finished, push the task to be uploaded
         // we need this since the task might have been interrupted
         // half way though
-        if (complete) this->interface.push_finished(std::move(task));
+        if (complete) this->interface.push_finished(std::move(output));
     }
 }
 
-bool Worker::perform_task(std::unique_ptr<Task>& task) {
+std::unique_ptr<OutputType> Worker::perform_task(std::unique_ptr<InputType> task, bool& finished) {
     usleep(1000000);
     std::cout << "[WORKER] Worker performed task. Please implement me!" << std::endl;
-    task->uuid;
+    task->id;
-    return true;
+    auto output = std::make_unique<OutputType>();
+    return std::move(output);
 
     // wait for either the executing process to finish or 
     // for the condition variable indicating the process should be stopped